Skip to content

generate: Add power decay spatial profile#4489

Open
cwindolf wants to merge 4 commits intoSpikeInterface:mainfrom
cwindolf:generate-spatial-profile
Open

generate: Add power decay spatial profile#4489
cwindolf wants to merge 4 commits intoSpikeInterface:mainfrom
cwindolf:generate-spatial-profile

Conversation

@cwindolf
Copy link
Copy Markdown
Collaborator

@cwindolf cwindolf commented Apr 1, 2026

This PR adds another spatial decay family to the template simulator. Instead of just exponential, there's also a power law type decay.

I'd like to switch over totally to SpikeInterface for my simulation studies, and with this and the temporal correlations thing I think that should be enough for me.

@cwindolf cwindolf added enhancement New feature or request generators Related to generator tools labels Apr 1, 2026
@cwindolf
Copy link
Copy Markdown
Collaborator Author

cwindolf commented Apr 1, 2026

I think the test fails are unrelated?

@alejoe91 alejoe91 mentioned this pull request Apr 2, 2026
@alejoe91
Copy link
Copy Markdown
Member

alejoe91 commented Apr 2, 2026

I think the test fails are unrelated?

yes very unrelated. should be fixed by #4490

@chrishalcrow
Copy link
Copy Markdown
Member

Yeah, weird test failure. The complete tests should not be trying to include .github/scripts/test_kilosort4_ci.py. I'll look into it...

@cwindolf
Copy link
Copy Markdown
Collaborator Author

cwindolf commented Apr 3, 2026

The test fail seems to happen because in "src/spikeinterface/preprocessing/tests/test_pipeline.py::test_loading_provenance", there is a place where bad channels are detected and discarded; this discards all the channels and there is some file-seek thing where .seek(0 - 1) is called because the data size is 0.

It passes locally for me, but it seems like my 2 PRs are the only ones where this test fails? I am a bit confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request generators Related to generator tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants